mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-11-13 14:51:12 +08:00
Andrew ChenandClaude Opus 4.8
77ed0aed43
Fix ensure_v1() mangling Gemini's v1beta/openai endpoint by appending /v1. Now recognizes any segment starting with v{digit} as already versioned.
Signed-off-by: chuenchen309 <48723787+chuenchen309@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
60 lines
2.3 KiB
Python
60 lines
2.3 KiB
Python
#
|
|
# Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
"""
|
|
Unit tests for rag/utils/url_utils.py module.
|
|
"""
|
|
|
|
import pytest
|
|
from rag.utils.url_utils import ensure_v1
|
|
|
|
|
|
class TestEnsureV1:
|
|
def test_empty_url_returned_unchanged(self):
|
|
assert ensure_v1("") == ""
|
|
|
|
def test_bare_host_gets_v1_appended(self):
|
|
assert ensure_v1("https://api.example.com") == "https://api.example.com/v1"
|
|
|
|
def test_already_versioned_unchanged(self):
|
|
assert ensure_v1("https://api.example.com/v1") == "https://api.example.com/v1"
|
|
|
|
def test_versioned_with_trailing_path_unchanged(self):
|
|
assert ensure_v1("https://api.example.com/v2/chat") == "https://api.example.com/v2/chat"
|
|
|
|
def test_versioned_with_leading_path_unchanged(self):
|
|
assert ensure_v1("https://api.example.com/api/v3") == "https://api.example.com/api/v3"
|
|
|
|
@pytest.mark.parametrize(
|
|
"url",
|
|
[
|
|
"https://generativelanguage.googleapis.com/v1beta/openai/",
|
|
"https://generativelanguage.googleapis.com/v1beta/openai",
|
|
"https://example.com/v1alpha1",
|
|
],
|
|
)
|
|
def test_version_suffix_with_letters_is_recognized(self, url):
|
|
"""A path segment like v1beta/v1alpha1 is already versioned - real
|
|
OpenAI-compatible endpoints (e.g. Google's Gemini API) use this
|
|
pattern, and ensure_v1 must not append a second /v1 onto it."""
|
|
assert ensure_v1(url) == url
|
|
|
|
def test_non_version_segment_starting_with_v_still_gets_v1(self):
|
|
"""A segment like 'vendors' merely starting with the letter v (with
|
|
no digit right after) is not a version segment - /v1 must still be
|
|
appended."""
|
|
assert ensure_v1("https://api.example.com/vendors/list") == "https://api.example.com/vendors/list/v1"
|